Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

sample/contact/AddPermission.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	30
	Variable 'contact' must be private and have accessor methods.	30
	Missing a Javadoc comment.	31
	Variable 'permission' must be private and have accessor methods.	31
	Missing a Javadoc comment.	32
	Variable 'recipient' must be private and have accessor methods.	32
	Method 'setContact' is not designed for extension - needs to be abstract, final or empty.	36
	Missing a Javadoc comment.	36
	Parameter contact should be final.	36
	'contact' hides a field.	36
	Method 'getContact' is not designed for extension - needs to be abstract, final or empty.	40
	Missing a Javadoc comment.	40
	Method 'setPermission' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44
	Parameter permission should be final.	44
	'permission' hides a field.	44
	Method 'getPermission' is not designed for extension - needs to be abstract, final or empty.	48
	Missing a Javadoc comment.	48
	Method 'setRecipient' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	Parameter recipient should be final.	52
	'recipient' hides a field.	52
	Method 'getRecipient' is not designed for extension - needs to be abstract, final or empty.	56
	Missing a Javadoc comment.	56

sample/contact/AddPermissionController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	46
	Missing a Javadoc comment.	52
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	56
	Missing a Javadoc comment.	56
	Parameter contact should be final.	56
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	60
	Missing a Javadoc comment.	60
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	64
	Missing a Javadoc comment.	64
	Method 'disallowDuplicateFormSubmission' is not designed for extension - needs to be abstract, final or empty.	69
	Missing a Javadoc comment.	69
	Parameter request should be final.	70
	Parameter response should be final.	70
	Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty.	80
	Missing a Javadoc comment.	80
	Parameter request should be final.	80
	Method 'handleInvalidSubmit' is not designed for extension - needs to be abstract, final or empty.	93
	Missing a Javadoc comment.	93
	Parameter request should be final.	93
	Parameter response should be final.	94
	Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty.	98
	Missing a Javadoc comment.	98
	Parameter request should be final.	98
	Parameter response should be final.	99
	Parameter command should be final.	99
	Parameter errors should be final.	99
	Method 'referenceData' is not designed for extension - needs to be abstract, final or empty.	117
	Missing a Javadoc comment.	117
	Parameter request should be final.	117
	Missing a Javadoc comment.	126
	Parameter request should be final.	126
	Missing a Javadoc comment.	147
	Parameter request should be final.	147

sample/contact/AddPermissionValidator.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	29
	Method 'supports' is not designed for extension - needs to be abstract, final or empty.	34
	Missing a Javadoc comment.	34
	Parameter clazz should be final.	34
	Method 'validate' is not designed for extension - needs to be abstract, final or empty.	38
	Missing a Javadoc comment.	38
	Parameter obj should be final.	38
	Parameter errors should be final.	38
	'100' is a magic number.	60

sample/contact/AdminPermissionController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	43
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49
	Method 'setAclManager' is not designed for extension - needs to be abstract, final or empty.	53
	Missing a Javadoc comment.	53
	Parameter aclManager should be final.	53
	'aclManager' hides a field.	53
	Method 'getAclManager' is not designed for extension - needs to be abstract, final or empty.	57
	Missing a Javadoc comment.	57
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	61
	Missing a Javadoc comment.	61
	Parameter contact should be final.	61
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	65
	Missing a Javadoc comment.	65
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	69
	Missing a Javadoc comment.	69
	Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty.	75
	Missing a Javadoc comment.	75
	Parameter request should be final.	75
	Parameter response should be final.	76

sample/contact/ClientApplication.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	39
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Parameter beanFactory should be final.	53
	'beanFactory' hides a field.	53
	Method 'invokeContactManager' is not designed for extension - needs to be abstract, final or empty.	59
	Missing a Javadoc comment.	59
	Parameter authentication should be final.	59
	Parameter nrOfCalls should be final.	60
	Line is longer than 80 characters.	63
	Line is longer than 80 characters.	86
	Line is longer than 80 characters.	106
	Must have at least one statement.	107
	'{' is not followed by whitespace.	107
	'}' is not preceded with whitespace.	107
	'}' should be on the same line.	107
	Must have at least one statement.	108
	'{' is not followed by whitespace.	108
	'}' is not preceded with whitespace.	108
	Line is longer than 80 characters.	110
	Missing a Javadoc comment.	143
	Parameter args should be final.	143
	Line is longer than 80 characters.	150
	Line is longer than 80 characters.	151
	Line is longer than 80 characters.	152
	Line is longer than 80 characters.	153
	Line is longer than 80 characters.	162

sample/contact/Contact.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	36
	Parameter name should be final.	36
	'name' hides a field.	36
	Parameter email should be final.	36
	'email' hides a field.	36
	Missing a Javadoc comment.	41
	'{' is not followed by whitespace.	41
	'}' is not preceded with whitespace.	41
	Method 'setEmail' is not designed for extension - needs to be abstract, final or empty.	50
	Parameter email should be final.	50
	'email' hides a field.	50
	Method 'getEmail' is not designed for extension - needs to be abstract, final or empty.	59
	Method 'setId' is not designed for extension - needs to be abstract, final or empty.	63
	Missing a Javadoc comment.	63
	Parameter id should be final.	63
	'id' hides a field.	63
	Method 'getId' is not designed for extension - needs to be abstract, final or empty.	72
	Method 'setName' is not designed for extension - needs to be abstract, final or empty.	81
	Parameter name should be final.	81
	'name' hides a field.	81
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	90
	Method 'toString' is not designed for extension - needs to be abstract, final or empty.	94
	Missing a Javadoc comment.	94

sample/contact/ContactDao.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	30
	Redundant 'public' modifier.	30
	Missing a Javadoc comment.	32
	Redundant 'public' modifier.	32
	Missing a Javadoc comment.	34
	Redundant 'public' modifier.	34
	Missing a Javadoc comment.	36
	Redundant 'public' modifier.	36
	Missing a Javadoc comment.	38
	Redundant 'public' modifier.	38
	Missing a Javadoc comment.	40
	Redundant 'public' modifier.	40
	Missing a Javadoc comment.	42
	Redundant 'public' modifier.	42

sample/contact/ContactDaoSpring.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Method 'getById' is not designed for extension - needs to be abstract, final or empty.	51
	Missing a Javadoc comment.	51
	Parameter id should be final.	51
	Method 'create' is not designed for extension - needs to be abstract, final or empty.	61
	Missing a Javadoc comment.	61
	Parameter contact should be final.	61
	Method 'delete' is not designed for extension - needs to be abstract, final or empty.	67
	Missing a Javadoc comment.	67
	Parameter contactId should be final.	67
	Method 'findAll' is not designed for extension - needs to be abstract, final or empty.	71
	Missing a Javadoc comment.	71
	Method 'findAllPrincipals' is not designed for extension - needs to be abstract, final or empty.	75
	Missing a Javadoc comment.	75
	Method 'findAllRoles' is not designed for extension - needs to be abstract, final or empty.	79
	Missing a Javadoc comment.	79
	Method 'update' is not designed for extension - needs to be abstract, final or empty.	83
	Missing a Javadoc comment.	83
	Parameter contact should be final.	83
	Method 'initDao' is not designed for extension - needs to be abstract, final or empty.	87
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	97
	Parameter contact should be final.	97
	Missing a Javadoc comment.	103
	Missing a Javadoc comment.	105
	Parameter ds should be final.	105
	Method 'mapRow' is not designed for extension - needs to be abstract, final or empty.	112
	Missing a Javadoc comment.	112
	Parameter rs should be final.	112
	Parameter rownum should be final.	112
	Missing a Javadoc comment.	118
	Missing a Javadoc comment.	119
	Parameter ds should be final.	119
	Method 'insert' is not designed for extension - needs to be abstract, final or empty.	128
	Missing a Javadoc comment.	128
	Parameter objectIdentity should be final.	128
	Parameter parentAclObjectIdentity should be final.	129
	Parameter aclClass should be final.	129
	Line is longer than 80 characters.	130
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	138
	Parameter ds should be final.	138
	Method 'delete' is not designed for extension - needs to be abstract, final or empty.	144
	Missing a Javadoc comment.	144
	Parameter contactId should be final.	144
	Missing a Javadoc comment.	149
	Missing a Javadoc comment.	150
	Parameter ds should be final.	150
	Method 'insert' is not designed for extension - needs to be abstract, final or empty.	158
	Missing a Javadoc comment.	158
	Parameter contact should be final.	158
	Line is longer than 80 characters.	159
	Missing a Javadoc comment.	165
	Missing a Javadoc comment.	166
	Parameter ds should be final.	166
	Line is longer than 80 characters.	168
	Method 'update' is not designed for extension - needs to be abstract, final or empty.	175
	Missing a Javadoc comment.	175
	Parameter contact should be final.	175
	Line is longer than 80 characters.	176
	Missing a Javadoc comment.	182
	Missing a Javadoc comment.	183
	Parameter ds should be final.	183
	Line is longer than 80 characters.	184
	Method 'mapRow' is not designed for extension - needs to be abstract, final or empty.	188
	Missing a Javadoc comment.	188
	Parameter rs should be final.	188
	Parameter rownum should be final.	188
	Missing a Javadoc comment.	199
	Missing a Javadoc comment.	200
	Parameter ds should be final.	200
	Line is longer than 80 characters.	202
	Method 'mapRow' is not designed for extension - needs to be abstract, final or empty.	207
	Missing a Javadoc comment.	207
	Parameter rs should be final.	207
	Parameter rownum should be final.	207
	Missing a Javadoc comment.	218
	Missing a Javadoc comment.	219
	Parameter ds should be final.	219
	Line is longer than 80 characters.	221
	Method 'delete' is not designed for extension - needs to be abstract, final or empty.	227
	Missing a Javadoc comment.	227
	Parameter aclObjectIdentity should be final.	227
	Parameter recipient should be final.	227
	Missing a Javadoc comment.	232
	Missing a Javadoc comment.	233
	Parameter ds should be final.	233
	Method 'insert' is not designed for extension - needs to be abstract, final or empty.	242
	Missing a Javadoc comment.	242
	Parameter aclObjectIdentity should be final.	242
	Parameter recipient should be final.	242
	Parameter mask should be final.	243
	Line is longer than 80 characters.	244
	Missing a Javadoc comment.	251
	Missing a Javadoc comment.	252
	Parameter ds should be final.	252
	Method 'mapRow' is not designed for extension - needs to be abstract, final or empty.	257
	Missing a Javadoc comment.	257
	Parameter rs should be final.	257
	Parameter rownum should be final.	257
	Missing a Javadoc comment.	263
	Missing a Javadoc comment.	264
	Parameter ds should be final.	264
	Line is longer than 80 characters.	266
	Method 'mapRow' is not designed for extension - needs to be abstract, final or empty.	270
	Missing a Javadoc comment.	270
	Parameter rs should be final.	270
	Parameter rownum should be final.	270

sample/contact/ContactManager.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	30
	Redundant 'public' modifier.	30
	Missing a Javadoc comment.	32
	Redundant 'public' modifier.	32
	Missing a Javadoc comment.	34
	Redundant 'public' modifier.	34
	Missing a Javadoc comment.	36
	Redundant 'public' modifier.	36
	Missing a Javadoc comment.	38
	Redundant 'public' modifier.	38
	Missing a Javadoc comment.	41
	Redundant 'public' modifier.	41
	Missing a Javadoc comment.	43
	Redundant 'public' modifier.	43
	Missing a Javadoc comment.	45
	Redundant 'public' modifier.	45

sample/contact/ContactManagerBackend.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	40
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	'1000' is a magic number.	48
	Method 'getAll' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	Method 'getAllRecipients' is not designed for extension - needs to be abstract, final or empty.	60
	Missing a Javadoc comment.	60
	Line is longer than 80 characters.	71
	Method 'setBasicAclExtendedDao' is not designed for extension - needs to be abstract, final or empty.	71
	Missing a Javadoc comment.	71
	Parameter basicAclExtendedDao should be final.	71
	'basicAclExtendedDao' hides a field.	71
	Method 'getBasicAclExtendedDao' is not designed for extension - needs to be abstract, final or empty.	75
	Missing a Javadoc comment.	75
	Method 'getById' is not designed for extension - needs to be abstract, final or empty.	79
	Missing a Javadoc comment.	79
	Parameter id should be final.	79
	Method 'setContactDao' is not designed for extension - needs to be abstract, final or empty.	87
	Missing a Javadoc comment.	87
	Parameter contactDao should be final.	87
	'contactDao' hides a field.	87
	Method 'getContactDao' is not designed for extension - needs to be abstract, final or empty.	91
	Missing a Javadoc comment.	91
	Method 'getRandomContact' is not designed for extension - needs to be abstract, final or empty.	100
	Method 'addPermission' is not designed for extension - needs to be abstract, final or empty.	112
	Missing a Javadoc comment.	112
	Parameter contact should be final.	112
	Parameter recipient should be final.	112
	Parameter permission should be final.	113
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	126
	Missing a Javadoc comment.	126
	Method 'create' is not designed for extension - needs to be abstract, final or empty.	131
	Missing a Javadoc comment.	131
	Parameter contact should be final.	131
	Line has trailing spaces.	136
	Line is longer than 80 characters.	142
	Method 'delete' is not designed for extension - needs to be abstract, final or empty.	146
	Missing a Javadoc comment.	146
	Parameter contact should be final.	146
	Method 'deletePermission' is not designed for extension - needs to be abstract, final or empty.	158
	Missing a Javadoc comment.	158
	Parameter contact should be final.	158
	Parameter recipient should be final.	158
	Method 'update' is not designed for extension - needs to be abstract, final or empty.	167
	Missing a Javadoc comment.	167
	Parameter contact should be final.	167
	Method 'getUsername' is not designed for extension - needs to be abstract, final or empty.	175
	Missing a Javadoc comment.	175
	Missing a Javadoc comment.	186
	Parameter contact should be final.	186

sample/contact/DataSourcePopulator.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	33
	Missing a Javadoc comment.	38
	Variable 'rnd' must be private and have accessor methods.	38
	Line is longer than 80 characters.	39
	Missing a Javadoc comment.	39
	Variable 'firstNames' must be private and have accessor methods.	39
	Line is longer than 80 characters.	40
	Missing a Javadoc comment.	40
	Variable 'lastNames' must be private and have accessor methods.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	'1000' is a magic number.	42
	Method 'setCreateEntities' is not designed for extension - needs to be abstract, final or empty.	46
	Missing a Javadoc comment.	46
	Parameter createEntities should be final.	46
	'createEntities' hides a field.	46
	Method 'getCreateEntities' is not designed for extension - needs to be abstract, final or empty.	50
	Missing a Javadoc comment.	50
	Method 'setDataSource' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Parameter dataSource should be final.	54
	'dataSource' hides a field.	54
	Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty.	58
	Missing a Javadoc comment.	58
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	62
	Method length is 151 lines (max allowed is 150).	62
	Missing a Javadoc comment.	62
	Line is longer than 80 characters.	68
	Line is longer than 80 characters.	70
	Line is longer than 80 characters.	72
	Line is longer than 80 characters.	74
	Line is longer than 80 characters.	76
	Line is longer than 80 characters.	78
	Line is longer than 80 characters.	80
	Line is longer than 80 characters.	82
	Line is longer than 80 characters.	84
	Line is longer than 80 characters.	86
	'10' is a magic number.	88
	Line is longer than 80 characters.	96
	Line is longer than 80 characters.	98
	Line is longer than 80 characters.	100
	Line is longer than 80 characters.	102
	Line is longer than 80 characters.	104
	Line is longer than 80 characters.	106
	Line is longer than 80 characters.	108
	Line is longer than 80 characters.	110
	Line is longer than 80 characters.	112
	Line is longer than 80 characters.	114
	'10' is a magic number.	116
	Line is longer than 80 characters.	123
	Line is longer than 80 characters.	125
	Line is longer than 80 characters.	127
	Line is longer than 80 characters.	129
	Line is longer than 80 characters.	131
	Line is longer than 80 characters.	133
	Line is longer than 80 characters.	137
	Line is longer than 80 characters.	139
	Line is longer than 80 characters.	143
	Line is longer than 80 characters.	145
	Line is longer than 80 characters.	149
	Line is longer than 80 characters.	151
	'22' is a magic number.	152
	'10' is a magic number.	154
	Line is longer than 80 characters.	170
	Line is longer than 80 characters.	172
	Line is longer than 80 characters.	174
	Line has trailing spaces.	185
	Line is longer than 80 characters.	188
	Line is longer than 80 characters.	190
	Line is longer than 80 characters.	192
	Line is longer than 80 characters.	194
	Line is longer than 80 characters.	196
	Line is longer than 80 characters.	198
	Line is longer than 80 characters.	200
	Line is longer than 80 characters.	207
	Line is longer than 80 characters.	208
	Missing a Javadoc comment.	214

sample/contact/DeleteController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	42
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	46
	Missing a Javadoc comment.	46
	Parameter contact should be final.	46
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	50
	Missing a Javadoc comment.	50
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty.	59
	Missing a Javadoc comment.	59
	Parameter request should be final.	59
	Parameter response should be final.	60

sample/contact/DeletePermissionController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	42
	Line is longer than 80 characters.	44
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Method 'setAclManager' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	Parameter aclManager should be final.	52
	'aclManager' hides a field.	52
	Method 'getAclManager' is not designed for extension - needs to be abstract, final or empty.	56
	Missing a Javadoc comment.	56
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	60
	Missing a Javadoc comment.	60
	Parameter contact should be final.	60
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	64
	Missing a Javadoc comment.	64
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	68
	Missing a Javadoc comment.	68
	Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty.	74
	Missing a Javadoc comment.	74
	Parameter request should be final.	74
	Parameter response should be final.	75

sample/contact/PublicIndexController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	35
	Missing a Javadoc comment.	40
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44
	Parameter contact should be final.	44
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	48
	Missing a Javadoc comment.	48
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	Line is longer than 80 characters.	53
	Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty.	56
	Missing a Javadoc comment.	56
	Parameter request should be final.	56
	Parameter response should be final.	57

sample/contact/SecureIndexController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	39
	Missing a Javadoc comment.	44
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	48
	Missing a Javadoc comment.	48
	Parameter contact should be final.	48
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty.	56
	Missing a Javadoc comment.	56
	Line is longer than 80 characters.	57
	Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty.	60
	Missing a Javadoc comment.	60
	Parameter request should be final.	60
	Parameter response should be final.	61

sample/contact/WebContact.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Method 'setEmail' is not designed for extension - needs to be abstract, final or empty.	32
	Missing a Javadoc comment.	32
	Parameter email should be final.	32
	'email' hides a field.	32
	Method 'getEmail' is not designed for extension - needs to be abstract, final or empty.	36
	Missing a Javadoc comment.	36
	Method 'setName' is not designed for extension - needs to be abstract, final or empty.	40
	Missing a Javadoc comment.	40
	Parameter name should be final.	40
	'name' hides a field.	40
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44

sample/contact/WebContactAddController.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	30
	Missing a Javadoc comment.	35
	Method 'setContactManager' is not designed for extension - needs to be abstract, final or empty.	39
	Missing a Javadoc comment.	39
	Parameter contactManager should be final.	39
	'contactManager' hides a field.	39
	Method 'getContactManager' is not designed for extension - needs to be abstract, final or empty.	43
	Missing a Javadoc comment.	43
	Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty.	47
	Missing a Javadoc comment.	47
	Parameter command should be final.	47
	Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty.	57
	Missing a Javadoc comment.	57
	Parameter request should be final.	57

sample/contact/WebContactValidator.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	26
	Method 'supports' is not designed for extension - needs to be abstract, final or empty.	31
	Missing a Javadoc comment.	31
	Parameter clazz should be final.	31
	Method 'validate' is not designed for extension - needs to be abstract, final or empty.	35
	Missing a Javadoc comment.	35
	Parameter obj should be final.	35
	Parameter errors should be final.	35
	'3' is a magic number.	38
	'50' is a magic number.	39
	'3' is a magic number.	44
	'50' is a magic number.	45

sample/contact/package.html

Error		Line
	Missing package documentation file.	0