##### Project Documentation

- About Acegi Security System for Spring - Contacts sample
- Downloads
- Project Info
- Project Reports
  - Change Log
  - Checkstyle
  - Clover
  - Metrics
  - Source Xref
  - PMD Report
  - Simian Report
  - Task List
  - FindBugs Report
- Development Process

## FindBugs Results

The following document contains the results of FindBugs.

## Summary

Files | Errors
--- | ---
22 | 32

## Files

Files | Violations
--- | ---
sample.contact.ClientApplication | 1
sample.contact.ContactDaoSpring | 8
sample.contact.DataSourcePopulator | 1
sample.contact.SecureIndexController | 2
sample.contact.AddPermissionController | 1
sample.contact.AdminPermissionController | 2
sample.contact.ContactManagerBackend | 2
sample.contact.DeleteController | 1
sample.contact.DeletePermissionController | 1
sample.contact.PublicIndexController | 1
sample.contact.WebContactAddController | 1
sample.contact.ContactDaoSpring$AclObjectIdentityByObjectIdentityQuery | 1
sample.contact.ContactDaoSpring$AclObjectIdentityInsert | 1
sample.contact.ContactDaoSpring$ContactDelete | 1
sample.contact.ContactDaoSpring$ContactInsert | 1
sample.contact.ContactDaoSpring$ContactUpdate | 1
sample.contact.ContactDaoSpring$ContactsAllQuery | 1
sample.contact.ContactDaoSpring$ContactsByIdQuery | 1
sample.contact.ContactDaoSpring$PermissionDelete | 1
sample.contact.ContactDaoSpring$PermissionInsert | 1
sample.contact.ContactDaoSpring$PrincipalsAllQuery | 1
sample.contact.ContactDaoSpring$RolesAllQuery | 1

### sample.contact.ClientApplication

Violation | Line
--- | ---
WMI: Method sample.contact.ClientApplication.invokeContactManager(org.acegisecurity.Authentication,int) makes inefficient use of keySet iterator instead of entrySet iterator | 110

### sample.contact.ContactDaoSpring

Violation | Line
--- | ---
UPM: Private method sample.contact.ContactDaoSpring.makeObjectIdentity(Contact) is never called | 98
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.contactDelete | 0
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.contactInsert | 0
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.contactUpdate | 0
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.contactsAllQuery | 0
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.contactsByIdQuery | 0
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.principalsAllQuery | 0
UwF: Field not initialized in constructor: sample.contact.ContactDaoSpring.rolesAllQuery | 0

### sample.contact.DataSourcePopulator

Violation | Line
--- | ---
Dm: Method sample.contact.DataSourcePopulator.afterPropertiesSet() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 90

### sample.contact.SecureIndexController

Violation | Line
--- | ---
ITA: Method sample.contact.SecureIndexController.handleRequest(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) uses Collection.toArray() with zero-length array argument | 68
UwF: Field not initialized in constructor: sample.contact.SecureIndexController.contactManager | 0

### sample.contact.AddPermissionController

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.AddPermissionController.contactManager | 0

### sample.contact.AdminPermissionController

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.AdminPermissionController.aclManager | 0
UwF: Field not initialized in constructor: sample.contact.AdminPermissionController.contactManager | 0

### sample.contact.ContactManagerBackend

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.ContactManagerBackend.basicAclExtendedDao | 0
UwF: Field not initialized in constructor: sample.contact.ContactManagerBackend.contactDao | 0

### sample.contact.DeleteController

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.DeleteController.contactManager | 0

### sample.contact.DeletePermissionController

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.DeletePermissionController.contactManager | 0

### sample.contact.PublicIndexController

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.PublicIndexController.contactManager | 0

### sample.contact.WebContactAddController

Violation | Line
--- | ---
UwF: Field not initialized in constructor: sample.contact.WebContactAddController.contactManager | 0

### sample.contact.ContactDaoSpring$AclObjectIdentityByObjectIdentityQuery

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$AclObjectIdentityByObjectIdentityQuery be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$AclObjectIdentityInsert

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$AclObjectIdentityInsert be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$ContactDelete

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$ContactDelete be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$ContactInsert

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$ContactInsert be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$ContactUpdate

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$ContactUpdate be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$ContactsAllQuery

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$ContactsAllQuery be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$ContactsByIdQuery

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$ContactsByIdQuery be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$PermissionDelete

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$PermissionDelete be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$PermissionInsert

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$PermissionInsert be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$PrincipalsAllQuery

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$PrincipalsAllQuery be a _static_ inner class? | 0

### sample.contact.ContactDaoSpring$RolesAllQuery

Violation | Line
--- | ---
SIC: Should sample.contact.ContactDaoSpring$RolesAllQuery be a _static_ inner class? | 0